search

rgamble / libcsv

Fast and flexible CSV library written in pure ANSI C that can read and write CSV data.
GNU Lesser General Public License v2.1
181 stars 40 forks source link

added CMakeLists.txt to use with cmake #11

Closed ferkulat closed 6 years ago

ferkulat commented 6 years ago
ferkulat commented 6 years ago

I forgot to set version info in CMakeLists.txt. I am going to open a new PR

jay commented 6 years ago

For future reference if you add commits to the branch associated with a PR and push them then they are visible in the PR. And if you need to change the commits you can force push (git push -f). Also, it's easier to work from a topic branch (eg git fetch upstream; git checkout -b topic upstream/master) rather than master itself.

ferkulat commented 6 years ago

@jay Thank you for this info. About the topic branches. Do you mean: I can create a topic branch in my forked repo and then make a pull request for it? And the upstream repo owner can merge this into its master or any other branch?

Thank you in advance

jay commented 6 years ago

Make a branch in your local repo, work on it, then push it to your forked repo on github. When you go to your forked repo page it should detect the branch you just created and it will have a notice saying that you just created a branch with a green button create pull request.

clipboard01

If not then you can select the branch manually.

If you need to make changes to the pr then you just make them on your local branch and push that branch to github, and since the branch is associated with the pr that will update the pr as well. In many cases if nobody else is working on your work it's easier and cleaner just to force-push rather than add more commits to the branch. For example you forgot to add version info, you could add that info, amend the commit, then force push the amended commit. That change will then show in the pr without a trivial commit just for adding the version info.