SKOS import has revealed scheme.tags scope not restricting to scheme

rgarner / semantically-taggable

Sort-of-fork of acts_as_taggable_on, but where Tags exist in a more formal semantic Scheme

MIT License

4 stars 1 forks source link

Closed rgarner closed 13 years ago

rgarner commented 13 years ago

We'd expect

some_scheme.tags.find_by_name 'tax'

To restrict the SQL SELECT to the owning scheme. It does not appear to. Find out why and fix.

rgarner commented 13 years ago

It does, but the tests didn't.

Watch out for indiscriminate use of SemanticallyTaggable::Tag.find_by_name. It's dangerous. Prefer some_scheme.tags.find_by_name!

rgarner commented 13 years ago

Made importer play nicely with schemes. Closed by 1f4409656eb02da97a60ee32279a386880f1fe38.