search

rgaudin / tools

3 stars 13 forks source link

added new methods that accept datetime.datetime object #4

Closed abelayalew closed 3 years ago

abelayalew commented 3 years ago

i added two additional methods that accept datetime.datetime object and also returns datetime.datetime

rgaudin commented 3 years ago

@abelayalew all of this looks good but changing a remote repo's url and version 🧐? Is this an accidental PR or is it on purpose? README instructs to use the pypi package I own but you changed the url and version and obviously can't publish there. Let me know what you ultimately want and we'll sort it out. I'm fine publishing a new version off this.

abelayalew commented 3 years ago

@rgaudin I was not trying to change the URL, I was trying to add two methods that I think may simplify the conversion process, anyway my concern is to add those two methods to be published here.

rgaudin commented 3 years ago

OK, I'll merge that and publish a new version on pypi then. thank you

rgaudin commented 3 years ago

backported changes in a single commit using only code changes. Published it on original ethiopian_date package as 0.2 as well. thank you !

abelayalew commented 3 years ago

thanks for your time, but you still did not add those methods that I was trying to add :point_down: image

rgaudin commented 3 years ago

Those are not in the pull request…

abelayalew commented 3 years ago

okay, i really sorry for that, should i make a pull request again?

rgaudin commented 3 years ago

Yes. You should use the master branch of this repo, add your changes and do another PR. Or just copy/paste the code here and I'll add it as it's just those 2 methods

abelayalew commented 3 years ago

okay i created another PR