search

rgbkrk / covfefe

covfefe
BSD 3-Clause "New" or "Revised" License
421 stars 25 forks source link

fix: build #23

Closed big-kahuna-burger closed 7 years ago

Qix- commented 7 years ago

Was just about to do this; probably going to need alsa-oss as an apt addon - let me double check.

See https://github.com/rgbkrk/covfefe/pull/23#issuecomment-305293168.

big-kahuna-burger commented 7 years ago

We need up for grabs label so we don't step on each other toes.

big-kahuna-burger commented 7 years ago

Yep, you were right

Qix- commented 7 years ago

Add libasound2-dev to the packages list, not alsa-oss.

Qix- commented 7 years ago

Other than the previous nit, this fixes it. The tests need to be fixed, however - which is unrelated to the build itself.

Qix- commented 7 years ago

Thanks @big-kahuna-burger 💃 @rgbkrk can we get a patch bump and release? :D

rgbkrk commented 7 years ago

Will do. I've also added you on npm.