Closed rmohr closed 8 years ago
Would you be able to write a test for this?
Thanks for the contribution, seems to be aligned pretty well.
Rewrote it to comply with cgo 1.6 pointer rules. Thanks for the initial review.
I will add a test too.
I think you could wrap everything in C code. This way, you just have to invoke the C function from Go code and not handle all the callback and allocation stuff in Go code.
I think you could wrap everything in C code. This way, you just have to invoke the C function from Go code and not handle all the callback and allocation stuff in Go code.
I'll try it, but I don't think it would save me more than one or two C.free calls. Let's see..
Would you be able to write a test for this?
Done
Thanks for the contribution @rmohr, looking forward to having you around here.
Hi,
@rgbkrk great project.
I added basic user/password authentication to libvirt-go. The PR is not finished yet but it already works.
It would be gread if I could get some feedback.