rgbkrk / libvirt-go

[DEPRECATED] Go bindings for libvirt
https://github.com/libvirt/libvirt-go
MIT License
166 stars 50 forks source link

connection: do not unregister close callback on close #106

Closed vincentbernat closed 8 years ago

vincentbernat commented 8 years ago

This is done automatically and if the connection has been closed unexpectedly, this will trigger an error. We ignore the error but it can appear in the logs.

rgbkrk commented 8 years ago

There's not another way to check if it's closed first and then unregister the callback?

vincentbernat commented 8 years ago

In this case, this is not really important as the close callback is always unregistered automatically. However, we have the problem for other kind of callbacks that cannot be unregistered if the connection is closed unexpectedly. I have asked on the libvirt mailing list for some guidance on how to handle all that.