domain: add pinnings support to GetVCpus()

rgbkrk / libvirt-go

[DEPRECATED] Go bindings for libvirt

https://github.com/libvirt/libvirt-go

MIT License

166 stars 50 forks source link

domain: add pinnings support to GetVCpus() #112

Closed Leonid99 closed 7 years ago

mraygalaxy commented 7 years ago

LGTM. @rgbkrk comments?

rgbkrk commented 7 years ago

Thanks for rebasing, I almost commented on an old version of this since it was sitting in an idle tab.

mraygalaxy commented 7 years ago

@rgbkrk @Leonid99 is going to re-work this and break-out the individual libvirt functions into separate exports the same way it's done on the virsh client-side. The original will GetVcpus will stay the same.

Leonid99 commented 7 years ago

@hinesmr @rgbkrk I reworked this code quite a bit and also added support for 2 more functions. I'm closing this PR and creating a new one. Sorry for the noise.