rgbkrk / libvirt-go

[DEPRECATED] Go bindings for libvirt
https://github.com/libvirt/libvirt-go
MIT License
166 stars 50 forks source link

domain: Change vcpus uint setter to uint16 #121

Closed purpleidea closed 7 years ago

purpleidea commented 7 years ago

This makes it consistent with the GetNrVirtCpu method which returns uint16. Quoting the libvirt upstream: "65536 cpus ought to be enough for everybody"

This fixes GH issue #117

purpleidea commented 7 years ago

Please read https://github.com/rgbkrk/libvirt-go/issues/120 before merging :)

purpleidea commented 7 years ago

FWIW the status checks actually passed if you click on the travis page, but from my POV GH bugged out and didn't update the check message here.