search

rgbkrk / libvirt-go

[DEPRECATED] Go bindings for libvirt
https://github.com/libvirt/libvirt-go
MIT License
166 stars 50 forks source link

Mapping for errors #33

Closed cbosdo closed 10 years ago

cbosdo commented 10 years ago

Here is the patch without errors. string is not an interface, there is no String() function to implement there to match. However VirError.Error() returns the same string than the GetLastError() implementation

alexzorin commented 10 years ago

VIR_ERR_CPU_INCOMPATIBLE appears to have been added in 1.2.6 which is why build fails (test env only provides for 1.2.4).

Could you comment it from the PR until I figure out what to do about it?

fwiw ill probably bump the version of this lib and change the test env to use 1.2.6+

cbosdo commented 10 years ago

Just commented that one out. IMHO, it would be great to sync the binding with the latest and greatest libvirt version and tag/release a version of the binding for each new libvirt version.

alexzorin commented 10 years ago

Thanks

Unfortunately since the bindings are not 'complete' I'd end have to backport additions to 'old' versions (and already do for libvirt 0.9.x), which I'm not too keen on doing

In the end, its just a const, so whoever needs it can use the value directly

But any input on how to version this package is very welcome: dog

cbosdo commented 10 years ago

For the while, I don't really need that precise error constant, so it can be merged commented. For the while I can't see any long term solution for the versioning.

cbosdo commented 10 years ago

oh... looks like the drone has problems with this PR, and no details available

alexzorin commented 10 years ago

merged into master with thanks