search

rgbkrk / libvirt-go

[DEPRECATED] Go bindings for libvirt
https://github.com/libvirt/libvirt-go
MIT License
166 stars 50 forks source link

Adding new methods #4

Closed dorzheh closed 10 years ago

alexzorin commented 10 years ago

Thanks, added to master. I had to alter the signature of IsActive as it is capable of returning an error, but otherwise I've just added tests.

alexzorin commented 10 years ago

Oh, the other difference is that DomainDefineXML takes an xml string, and added your file-based version as a convenience func DomainDefineXMLFromFile.

dorzheh commented 10 years ago

Indeed, separating DomainDefineXML and DomainDefineXMLFromFile is very legitimate.Thanks