search

rgbkrk / libvirt-go

[DEPRECATED] Go bindings for libvirt
https://github.com/libvirt/libvirt-go
MIT License
166 stars 50 forks source link

Add VirDomainBlockStat #58

Closed feiskyer closed 8 years ago

feiskyer commented 8 years ago

Add VirDomainBlockStat to libvirt-go

feiskyer commented 8 years ago

@rgbkrk Any updates on this?

rgbkrk commented 8 years ago

Let's take it and try it out. Adding you on to help maintain and collaborate.

feiskyer commented 8 years ago

Thanks.

feiskyer commented 8 years ago

@rgbkrk Could you add a CI integration for safely checking new PRs?

rgbkrk commented 8 years ago

Sure, seems like we need to find a good place to do it. Running locally now.

feiskyer commented 8 years ago

Try https://travis-ci.org ?

rgbkrk commented 8 years ago

That's what I use on everything else, wasn't sure if we'd have enough flexibility there. Happily enabled anyway.

alexzorin commented 8 years ago

My 2c: I think there were maybe problems running on travis because of how Docker and libvirt interact, which is why the tests run in vagrant/virtualbox. Might have something to do with privileged containers? Suggest validating these vague memories one way or another, though. drone.io was another contender.

rgbkrk commented 8 years ago

That definitely makes sense. Ran the tests locally by the way, using the vagrant set up. Enabled drone.io as well, happy to run that on carina as well if we want to run our own base image.

feiskyer commented 8 years ago

There is a TRUSTY BETA VM based environment on travis: https://docs.travis-ci.com/user/ci-environment/#Virtualization-environments.

It should be OK to run tests.