search

rgbkrk / libvirt-go

[DEPRECATED] Go bindings for libvirt
https://github.com/libvirt/libvirt-go
MIT License
166 stars 50 forks source link

add virDomainInterfaceAddresses #79

Closed dmacvicar closed 8 years ago

dmacvicar commented 8 years ago

As discussed in https://github.com/rgbkrk/libvirt-go/issues/50 , here is the implementation of virDomainInterfaceAddresses.

Requires libvirt 1.2.14.

As this call is not implemented in the test and lxc drivers, and even for QEMU would require booting an OS with DHCP client, the test currently only tests that the call succeeds and returns 0 addresses.

I am preparing another PR with an alternative vagrant file that allows to run the integration tests on openSUSE Leap 42.1, that uses libvirt-1.2.18.2.

rgbkrk commented 8 years ago

Merged #83, should we close this one for now?

dmacvicar commented 8 years ago

Yes, IIRC the other included this one.