search

rgbkrk / libvirt-go

[DEPRECATED] Go bindings for libvirt
https://github.com/libvirt/libvirt-go
MIT License
166 stars 50 forks source link

Add SetKeepAlive() function to enable keepalive probes #92

Closed vincentbernat closed 8 years ago

vincentbernat commented 8 years ago

The test needs a real QEMU connection as this feature is not supported by the test driver. Also, the documentation mentions the return code is -1 for generic errors and 1 if the remote end doesn't support keepalives. However, a quick test shows that the test backend will just return -1. virsh is just testing if the return code is different of

  1. Therefore, it seems safer to trigger an error if return code != 0.
vincentbernat commented 8 years ago

The virConnectSetKeepAlive() function was introduced in libvirt 0.9.8. So, we are in the target.

rgbkrk commented 8 years ago

Great! Thanks for the note on API compatibility as well.