rgbpokka / pe

0 stars 0 forks source link

Different resident with exact same details can be added into the residents book #2

Open rgbpokka opened 2 years ago

rgbpokka commented 2 years ago

Steps to reproduce:

  1. Enter add n/John Doe p/98765432 e/johnd@example.com r/A100 v/t f/SoC
  2. Then enter add n/John Mary p/98765432 e/johnd@example.com r/A417 v/t f/SoC

It is not possible for another resident to have the exact same phone number and email.

image.png

image.png

nus-pe-bot commented 2 years ago

Team's Response

Screenshot 2021-11-15 at 4.58.22 PM.png

As stated in the UG, only name and room are unique identifiers for a person. Phone and email are not included.
Additionally, we also cannot rule out the possibility of multiple persons sharing an email address or any other circumstances that may require them to have the same email. Thus, limiting email uniqueness may be too restrictive for the users.
It may also be too restrictive to limit phone numbers because if this application were to be used in places with residential suites that have a common home phone line, residents cannot be allocated the same phone number if they wish to be contacted primarily by their home lines.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]


:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Low]

Reason for disagreement: [replace this with your explanation]