rgbpokka / pe

0 stars 0 forks source link

No check as to whether phone number is valid #5

Open rgbpokka opened 2 years ago

rgbpokka commented 2 years ago

Given that the context of this application is Local Halls, there should be some form of check as to whether the phone number provided is valid, so that the resident may be contacted when needed. However, I am able to enter an invalid local phone number as shown:

image.png

nus-pe-bot commented 2 years ago

Team's Response

Considering international students can be residents of halls, they may still be using their home numbers. In light of this, there are simply too many considerations. Area codes, "+" and "*" are all valid phone number details. Furthermore, hall administrators are likely to possess a list of valid phone numbers in the first place, it is very unlikely that hall admins should have the responsibility to do validity checks on phone numbers.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: [replace this with your explanation]