search

rgcca-factory / RGCCA

https://rgcca-factory.github.io/RGCCA/
10 stars 11 forks source link

Create svd_wrapper and copy ginv to avoid LAPACK errors #83

Open GFabien opened 3 months ago

GFabien commented 3 months ago

Wrap the calls to the svd function in the RGCCA package into the svd_wrapper function to avoid LAPACK errors as done in the JIVE package. SVD are performed in RGCCA in the block initializations (when init = TRUE) and through the calls to the MASS::ginv function. Therefore, this last function has been reimplemented in the package and calls the wrapper instead of the original SVD function.

Aims to solve #82.

codecov-commenter commented 3 months ago

Codecov Report

Attention: Patch coverage is 68.42105% with 18 lines in your changes are missing coverage. Please review.

Project coverage is 94.56%. Comparing base (eefad3b) to head (fa8b370).

:exclamation: Current head fa8b370 differs from pull request most recent head be97b1b

Please upload reports for the commit be97b1b to get more accurate results.

Files Patch % Lines
R/svd_wrapper.R 47.36% 10 Missing :warning:
R/ginv.R 71.42% 4 Missing :warning:
R/block_project.R 75.00% 3 Missing :warning:
R/deflation.R 80.00% 1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #83 +/- ## ========================================== - Coverage 95.02% 94.56% -0.47% ========================================== Files 80 82 +2 Lines 3138 3185 +47 ========================================== + Hits 2982 3012 +30 - Misses 156 173 +17 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.