rgcr / m-cli

 Swiss Army Knife for macOS
MIT License
9.69k stars 312 forks source link

Make finder subcommands consistent #70

Closed elyscape closed 8 years ago

elyscape commented 8 years ago

The new m finder desktop subcommand takes as arguments enable and disable, lowercase only. This is in contrast to m finder showhiddenfiles and m finder showextensions, which both take yes and no case-insensitively. Additionally, the bash completion will only suggest YES and NO. This should be unified so that m finder desktop takes yes and no case-insensitively. Alternatively, all three commands could be extended to take yes, no, enable, and disable case-insensitively.

Additionally, both showhiddenfiles and showextensions are clear in what they mean: showhiddenfiles means the finder will show hidden files and showextensions means that the finder will show file extensions. desktop is vague. It should probably be renamed to showdesktop.

elyscape commented 8 years ago

Additionally, if you disable showing file extensions in the finder, it deletes the AppleShowAllExtensions key, causing an error to be shown by m finder showextensions.