search

rgd87 / Aptechka

WoW Addon - Raid Frames
http://www.wowinterface.com/downloads/info14339-Injector.html
33 stars 9 forks source link

[Classic] Shaman color #17

Closed lorem-ipsum-dolor-sit closed 4 years ago

lorem-ipsum-dolor-sit commented 4 years ago

https://github.com/rgd87/Aptechka/blob/6485eb658ce5d606406cca4eef2bf02581013727/Aptechka.lua#L302-L310

you can set the shaman color globally, so all addons profit and the UI is not inconsistent

RAID_CLASS_COLORS['SHAMAN']["r"] = 0.25
RAID_CLASS_COLORS['SHAMAN']["g"] = 0.32
RAID_CLASS_COLORS['SHAMAN']["b"] = 0.96
RAID_CLASS_COLORS['SHAMAN']["colorStr"] = "ff4254f5"
d87 commented 4 years ago

It'll cause taint most likely

lorem-ipsum-dolor-sit commented 4 years ago

In other words, you don't want a consistent user experience? Example PlayerFrames, Chat, Details are still pink but your frame is blue :D

After using the strings for weeks as a weak aura and it doesn't break any other addons.

d87 commented 4 years ago

No, i don't want my addon causing taint ( https://wow.gamepedia.com/Secure_Execution_and_Tainting ) And even if it was safe to write to RAID_CLASS_COLORS, it's still not the place of unitframe addon to make these global changes. I did what i can to safely make it blue because i hate the pink too. The rest is either the responsiblity of chat addon etc authors, or the users who can install https://www.wowinterface.com/downloads/info25310-ShamanFix.html and then their taint is not my problem The established safe way of changing class colors is supporting this addon, which i do https://www.wowinterface.com/downloads/info12513-ClassColors.html