search

rgd87 / LibClassicDurations

Provides duration expiration time for common auras via combat log
32 stars 14 forks source link

Issue with Improved Scorch / Fire Vulnerability at 5 stacks #64

Open Olorun opened 4 years ago

Olorun commented 4 years ago

Sometimes the duration of the Fire Vulnerability debuff (https://classic.wowhead.com/spell=22959/fire-vulnerability) fails to refresh once it has reached 5 stacks. It seems to occur when there's more than one mage applying the debuff during raids. When I tested it with only a 2 mage group there were no issues, but I've heard reports of it from raid encounters.

d87 commented 4 years ago

Only your personal scorches are supposed to refresh it, because you don't know if other mages have the talent. Maybe that's why

Olorun commented 4 years ago

Is there some way to implement non-personal scorches? Since nearly everyone is using this library in some form or another, maybe having some kind of talent check which is then shared with others could be the solution? I understand it's not directly the scope of the library, but this is going to be pretty high priority for mages once AQ comes out, so anything to solve this would be greatly appreciated.

d87 commented 4 years ago

Well I can allow all scorches. But it is what it is because i assumed a dedicated person with a talent would be doing it anyway. I don't actually know how often mages use scorch other than for Fire Vulnerability

Olorun commented 4 years ago

Once Phase 5 is out, pretty much every fire mage will have the talent. Scorch is not part of the "standard" damage rotation, but some will use it to keep up Ignite. For longer fights, mages will swap from Fireball to Scorch once they get to low mana. So Scorch does get cast often enough, although pretty much everyone will have the talent so it shouldn't be a concern (once AQ is out).

d87 commented 4 years ago

Ok, now it's any scorch. I'm not going to do comms, it's not worth the trouble.

altsor commented 3 years ago

Hey I don't know if anyone is still actively updating this, but there is an issue here that the fire vuln stack timer now resets even if the fire vuln debuff resisted. This leads to the debuff falling off because everyone thought it was refreshed when it wasn't. I can see how this is happening since the fix to the 5 stack refresh problem was solved by just looking at scorch hits.

Problem is that scorch can hit, while fire vuln resists. Check log at 01:13 of loatheb fight. Resists , Scorch hits Scorch from Oberman lands but debuff resists. One way to fix this would maybe be to add a filter to check so there isn't a resisted fire vuln in the log before resetting the timer.

I know its a pretty minor issue but would still be nice if anyone has time to fix it.