Pop-up doesn't work under IE6-8

GoogleCodeExporter commented 9 years ago

What steps will reproduce the problem?
1. Set the LTI display mode to 'pop-up' 
2. Link an LTI resource in Moodle
3. Visit the LTI resource using Internet Explorer versions 6 to 8 

What is the expected output? What do you see instead?

The pop-up never appears, and an error message is accessible from the task bar 
- indicating a javascript error.

What version of the product are you using? On what operating system?

Not really applicable, but this only occurs on IE / XP using the current 
version of BasicLTI. Firefox on WinXP works fine.

Please provide any additional information below.

The following line in view.php is the culprit:

print "window.open('launch.php?id=".$cm->id."','window name');";

IE doesn't tolerate spaces in window names. The problem goes away if we change 
'window name' to 'window_name'

Original issue reported on code.google.com by ferrisox...@gmail.com on 29 Nov 2011 at 5:35

GoogleCodeExporter commented 9 years ago

Original comment by ngalanis@gmail.com on 8 Feb 2012 at 10:42

GoogleCodeExporter commented 9 years ago

Original comment by ngalanis@gmail.com on 8 Feb 2012 at 10:58

Changed state: Started

rgegriff / basiclti4moodle

Pop-up doesn't work under IE6-8 #24