Closed f-amerehi closed 1 year ago
Hi @f-amerehi thanks so much for your pull request, that's very much appreciated! I just have a single question regarding whether 'from typing import Optional' can be removed; happy to merge otherwise.
Regarding the Eidolon repository, perhaps you could add a sentence or two to https://github.com/rgeirhos/generalisation-humans-DNNs#code describing your fix and linking to your repository? I think it's best to keep the Eidolon repo separated, but it might be helpful for future readers to know what you've fixed and we could link your repo from there if you like?
Yes, perhaps adding a line ease up applying Eidolon too. For Eidolon, I fixed some bugs. And one can install it via: "pip install git+https://github.com/f-amerehi/Eidolon.git".
Thank you very much!
Thanks again for the PR, much appreciated!
Thank you very much for the great paper and codes. Have a good day!
Hi @rgeirhos, I hope that all is well. I have also fixed issues on Eidolon and have packaged it for installation via
pip install git+https://github.com/f-amerehi/Eidolon.git
(although this isn't included in this PR). Should I include it to make using this repository easier? Thanks