search

rgeissert / http-redirector

Debian mirrors HTTP redirector
http://httpredir.debian.org/
88 stars 8 forks source link

Include depth parameter in RFC6249-like Link headers #40

Closed kraai closed 11 years ago

kraai commented 11 years ago

This should fix issue #4 (including the project and tools directories this time).

rgeissert commented 11 years ago

Besides those two comments, this change would break the demo. Some changes to the javascript there should be needed (or better: a slightly better parser of the Link headers or even better: rewrite the whole demo thing as mentioned in ticket #28). I would probably look at omitting the depth parameter if it is 0, but that could be done at a later time.

Thanks for contributing by the way!

kraai commented 11 years ago

Thanks for catching all those problems. I've rewritten the commit. This version:

rgeissert commented 11 years ago

Thanks. The change is going live today.

Btw, do you have any specific use case for which you wanted the depth parameter to be included? As you might be aware, the Link headers are not included in response to GET requests since APT doesn't do anything useful with them.

kraai commented 11 years ago

No, I was just browsing the list of issues and that seemed like one that would be easy to implement.

Matt Kraai Program Engineer III Software Engineering

Abbott Medical Optics Inc. 1700 E. St. Andrew Place Santa Ana, CA 92705 United States

Ph: (714) 247 8848 Fax: (714) 247 8678 Matt.Kraai@amo.abbott.com mailto:Matt.Kraai@amo.abbott.com www.abbottmedicaloptics.com http://www.abbottmedicaloptics.com

This communication may contain information that is proprietary, confidential, or exempt from disclosure. If you are not the intended recipient, please note that any other dissemination, distribution, use or copying of this communication is strictly prohibited. Anyone who receives this message in error should notify the sender immediately by telephone or by return e-mail and delete it from his or her computer.

From: Raphael Geissert [mailto:notifications@github.com] Sent: Sunday, December 16, 2012 4:19 PM To: rgeissert/http-redirector Cc: Kraai, Matt Subject: Re: [http-redirector] Include depth parameter in RFC6249-like Link headers (#40)

Thanks. The change is going live today.

Btw, do you have any specific use case for which you wanted the depth parameter to be included? As you might be aware, the Link headers are not included in response to GET requests since APT doesn't do anything useful with them.

Reply to this email directly or view it on GitHub https://github.com/rgeissert/http-redirector/pull/40#issuecomment-11425 644 .

https://github.com/notifications/beacon/th_T95ncE36NNYrncECYNcDiITXqGGC pL7cky3E4ViDZ7vRrojWg3JhZ-eH7sK37.gif

rgeissert commented 11 years ago

I see, no hurry in enabling them for GET requests then.

Thanks again for your contribution.

Raphael Geissert - Debian Developer www.debian.org - get.debian.net