search

rgeo / activerecord-postgis-adapter

ActiveRecord connection adapter for PostGIS, based on postgresql and rgeo
Other
865 stars 230 forks source link

Proposal to remove jruby support #393

Open seuros opened 6 months ago

seuros commented 6 months ago

We should consider removing JRuby code from the GitHub Action as it is currently untested, and Rails 7.1 lacks official support.

It's unclear if there's active JRuby utilization.

BuonOmo commented 6 months ago

I do not see JRuby in the github action tests.yml. What is the GitHub Action you are referencing?

seuros commented 6 months ago

That what i said ! We are not testing it.

however we have code like this.

Jruby don't support rails 7.1 and this gem current release require ~> 7.1.0

BuonOmo commented 6 months ago

I would not act on it until there is a real need (e.g. some jruby user is complaining, or the jruby code is generating failures in the main codebase)

seuros commented 6 months ago

@BuonOmo , it not possible to install this gem with jruby. This is misleading in the readme.

keithdoggett commented 6 months ago

@seuros thanks for looking into that. Do you know if this new with ActiveRecord >7?

seuros commented 5 months ago

@keithdoggett, 7.1 is not released: https://github.com/jruby/activerecord-jdbc-adapter.

I could not make this adapter work with jruby and rails 7.0 either.

keithdoggett commented 5 months ago

@seuros got it thanks for that. It looks like it should be working for ActiveRecord 7.0 and 7.1 is under development. Do you have any idea why it's not working for 7.0 since it should be supported? Do we need to bump the version of the adapter?