search

rgeo / rgeo-activerecord

RGeo ActiveRecord extensions and tools for spatial connection adapters
Other
89 stars 63 forks source link

Allow activerecord 6.0 #48

Closed corneverbruggen closed 5 years ago

corneverbruggen commented 5 years ago

Sorry, should have tested against all specified ruby versions. ActiveRecord 6.0 requires at least ruby 2.5. Will update travis.yml accordingly.

teeparham commented 5 years ago

Thanks!

I made some related changes on master.

1) I added ruby 2.6 and updated the jruby version in master. We only need to test the latest jruby. 2) I updated the ENV variable in the Gemfile, so byebug should no longer be added to the appraisal gemfile.

Please do a couple things:

  1. Rebase on master. To resolve the conflict, you'll need to remove the old jruby version & just use the new one. You won't need the exception to exclude the 9.1.x.x version from the travis matrix.
  2. Remove the 2 commits about the travis branches that make no changes.
  3. The byebug ENV change means we shouldn't need the commit to manually remove byebug from the 6.0 appraisal's gemfille. If you re-generate it, it should not be there.

It might be easier to open a PR with only the gem version restriction, & add the 6.0 appraisal. Up to you.

corneverbruggen commented 5 years ago

Ok, created a new pull request in which I also updated to latest activerecord-6.0.0rc1