would actually get a different instance of spatial_factory_store at the beginning and the end (the first one doesn't necessarily have default set, the second one does).
Another issue is this one:
# in initializer
spatial_factory_store.default = some_default
# later in the codebase
factory = spatial_factory_store.default(specific_attributes)
# the `specific_attributes` will not be taken into account
Issue create from this discussion: https://github.com/rgeo/activerecord-postgis-adapter/pull/412#discussion_r1800782440
The accessor for
#default
also behaves as a setter:This was messing up with the test suite in activerecord-postgis-adapter. Shall we find an API that is less error-prone?
For instance, a user doing:
would actually get a different instance of
spatial_factory_store
at the beginning and the end (the first one doesn't necessarily have default set, the second one does).Another issue is this one: