rgeo / rgeo-proj4

Proj4 extension for rgeo.
MIT License
13 stars 14 forks source link

Add Checks around Proj4 and CRSToCRS objects #26

Closed keithdoggett closed 2 years ago

keithdoggett commented 2 years ago

Fixes #25

keithdoggett commented 2 years ago

@BuonOmo thanks for the notes. And yeah I wanted to discuss if this was considered breaking. I think you're correct that it is, so I agree it should point to a different branch (v4-dev).

If that's the case I'll open up another issue with some other ideas I had that we can throw into a new major version.

keithdoggett commented 2 years ago

@BuonOmo I made all of the changes mentioned except for the one regarding marking the modules which needs more investigation. I'll also open up an issue for v4 shortly.

keithdoggett commented 2 years ago

@x4d3 if you have some time perhaps you could take a look through these changes since they affect the CRSToCRS module, which you're more familiar with than I am, and let me know if these make sense. Thanks!

x4d3 commented 2 years ago

🚀