rgeo / rgeo-proj4

Proj4 extension for rgeo.
MIT License
13 stars 14 forks source link

Add More Checks to Extconf #35

Closed keithdoggett closed 1 year ago

keithdoggett commented 1 year ago

Since this gem does not really have any functionality without Proj compiled, this PR adds stricter checks to ensure that all functions required for RGeo::Proj4.supported? are checked before compilation and the extconf will raise if they are not all met. Also adds more helpful error messages based on whether the cause of failure is proj not being found or an old version being found.

Since we are removing the dependency of the core gem on rgeo-proj4, the core gem won't need to call supported? anymore and this should be safe to do with RGeo 3+. Although I'm opening to allowing it to compile still and just leaving the warnings.

Related comment: https://github.com/rgeo/rgeo-proj4/issues/15#issuecomment-1269202794