search

rgeo / rgeo-proj4

Proj4 extension for rgeo.
MIT License
13 stars 14 forks source link

Patch extension to accept deprecated API #8

Closed keithdoggett closed 3 years ago

keithdoggett commented 3 years ago

Included ACCEPT_USE_OF_DEPRECATED_PROJ_API_H macro in extconf operations and main.c. This is a short term solution to #4 until a full upgrade can be done.

arkirchner commented 3 years ago

@keithdoggett I have tried this on Alpine Linus and it works well! Do you thin you can merge this and release a new gem version?

Thank you for your great work!

arkirchner commented 3 years ago

I tried converting the code to use <proj.h> this weekend. I didn't get far ... my knowledge is not enough at this point. I try my best to study but I am not sure if I can solve this. I hope someone smarter can do the conversion. The old <pro-apij.h> could be dropped very soon 😨

LocoDelAssembly commented 3 years ago

I tried converting the code to use <proj.h> this weekend. I didn't get far ... my knowledge is not enough at this point. I try my best to study but I am not sure if I can solve this. I hope someone smarter can do the conversion. The old <pro-apij.h> could be dropped very soon fearful

It is actually dropped already, on Mac proj 7.x gets installed with brew (https://formulae.brew.sh/formula/proj) which is not compatible with this patch.

Even with 6.x there are still specs failing, although don't know if them are actually required or it was just an integration test? I think EPSG:4326 and EPSG:3857 are now built-in and not need to be loaded manually from database, so the spec would require either test for proj4 version or test different SRS if the intent is just to check it can handle SRS data fine.

keithdoggett commented 3 years ago

I've merged this in and will release a new version soon.

@LocoDelAssembly I'm pretty sure the 2 failing tests in 6.x are ok, but yes v7.x is very broken still. I'm going to start the rewrite for this soon, I'm just trying to review all the issues across the ecosystem first but this is a high priority fix.

keithdoggett commented 3 years ago

Released this patch with version 2.0.1