search

rgeo / rgeo-proj4

Proj4 extension for rgeo.
MIT License
13 stars 14 forks source link

Ffi and proj4 v7 #9

Closed arkirchner closed 3 years ago

keithdoggett commented 3 years ago

Thank you for submitting this! I've been working on updating the C extension to use the new API as well, and I'll hopefully be done with that within a week.

I haven't worked with FFI in the past, so I'm more comfortable with the native C extensions, but I think that adding the Proj module at the very least should happen once everything is updated.

It looks like all the tests are currently failing on the ffi_lib call. Do you know the best way to handle that across systems?

arkirchner commented 3 years ago

@keithdoggett Sorry I wanted to open a PR on my fork of rgeo-proj4. I still in early development. I started with writing the C as well some time ago. However the changes in proj4 are very large. It was difficult to migrate this with the current interface.

ffi actually helps me to understand the proj4 library alot. I can use binding.pry to look into PJ objects. It helps a lot. It should actually not be difficult to transform the ffi code into C later.

You are only a week away from releasing. That is impressive! Do you want to create a branch with the current state of your work. Maybe I can help.

For now I will continue to implement this in ffi to get a better feeling for the proj4 lib.

I close the PR for now. It was very late for me yesterday night. 🤣 Some miss clicks were made.