search

rgerganov / py-air-control

Command line app for controlling Philips air purifiers
MIT License
266 stars 53 forks source link

Update README.md #47

Closed GSzabados closed 4 years ago

GSzabados commented 4 years ago

pip to pip3 and I believe the commit number is not necessary anymore.

rgerganov commented 4 years ago

Thank you for this fix. I agree about pip3 but let's keep the commit hash. I want to be sure that CoAPthon3 won't break our program if they commit something wrong in the master branch.

GSzabados commented 4 years ago

Try to install it with the command containing the commit. I saw a message in the console meanwhile installing, that it cannot find commit, so assumes master. (Or something similar.)

rgerganov commented 4 years ago

It says "Did not find branch or tag '89d5173', assuming revision or ref." which is fine.

rgerganov commented 4 years ago

I have updated your patch and merged it, thanks!