Use one base class for plain_coap and coap

rgerganov / py-air-control

Command line app for controlling Philips air purifiers

MIT License

256 stars 52 forks source link

Use one base class for plain_coap and coap #86

Open Cyber1000 opened 3 years ago

Cyber1000 commented 3 years ago

Since plain_coap has some similarities to coap (except the AES-encryption) I now use a common base between these two. That will also reduce the changes involved moving to another coap-libary (for example aiocoap) in the near future.

Tested with coap, need someone testing this with plain_coap

Depends on #85 (including commits from there), so should be merged afterwards

[x] Merge #85 before
[ ] Test if plain_coap is still working

Cyber1000 commented 3 years ago

To just see changes from this PR, have a look at https://github.com/Cyber1000/py-air-control/compare/master...Cyber1000:coap (sorry github doesn't provide dependant PRs)

rgerganov commented 3 years ago

Thanks, I have merged #85, please rebase.

Cyber1000 commented 3 years ago

rebased and tested (with coap)

rgerganov commented 3 years ago

Thanks! I wish someone can confirm if this works with plain coap before merging.

Cyber1000 commented 3 years ago

Hoping this too, I also have added a todo, cause I found something I didn't need in coap and don't think I'll need it in plain_coap, but can't verify it myself. I'll go on with my changes (in further PRs), hoping that meanwhile someone can test this.

todo

rgerganov commented 3 years ago

@shexbeer Could you please test this PR with your device? We want to make sure this change won't break the support for plain_coap. Thanks!