search

rgerum / unofficial-duolingo-stories

This project brings the official Duolingo Stories to new languages, translated by a community effort.
https://duostories.org
147 stars 29 forks source link

Remove overflow in admin dropdown #206

Closed meddhiaka closed 1 year ago

meddhiaka commented 1 year ago

This pull request addresses the issue #198 of overflow in the admin dropdown.

Changes Made: Removed the overflow property in the admin dropdown.

Testing: I have thoroughly tested the modified dropdown to ensure responsiveness in Microsoft Edge and Firefox. The dropdown renders correctly and adapts to different screen sizes without any overflow issues, I used the calc() CSS method to get a little unit of the viewport width, so it matches all screens.

Firefox screenshot: []()

Thank you!

rgerum commented 1 year ago

Did you move the blue circle? It seems a bit moved in the screenshot. How does it work with the courses drop down menu? The one that is not show in the screenshot, it shows up when you have completed a story.

meddhiaka commented 1 year ago

Yeah, it still takes effect in the upper bar without any issues. Here, you can see:

rgerum commented 1 year ago

but It looks like that you moved the blue circle to the left. This will create an issue with the header bar when using the editor, especially when directly editing a story because there the space is quite crowded there. I think the best solution might be to make the drop down menu a bit asymmetric on small screens. Or maybe even like a sidebar that slides in.