search

rgieseke / pandas-datapackage-reader

Data Package reader for Pandas
Other
19 stars 6 forks source link

Support different decimal chars and thousand separators #18

Closed ghost closed 4 years ago

ghost commented 4 years ago

Hi, I had to read some data with commas as thousand separators. This is supported in the Table Schema specification with keys decimalChar and groupChar. This PR adds support for both including tests.

Missing values were also checked in two places still: under resource top level and in the schema part. I removed the first, as it should be under schema.

All tests pass.

rgieseke commented 4 years ago

Good catch and thanks for the test files with self-explanatory names!

rgieseke commented 4 years ago

Pushed this as 0.17.0 to PyPI

ghost commented 4 years ago

Thanks, the quick merge is highly appreciated!