Closed pkazmier closed 11 years ago
Yes, enter
should work -- and it did in the past (some month ago). Now I just have to figure out when and why this broke ... The GUI version should work.
Ironic you mention GUI when textredux is all about text-based menus! :-) I appreciate you looking into it! Thanks!
I committed a workaround (https://github.com/rgieseke/textredux/commit/af452c181896ad0839265e23aa1e9d5a50f48142), could you test if this works for you?
I'll be looking into the upcoming key modes (http://foicica.com/hg/textadept/rev/47b4b51227c0), maybe Textredux can use them, too.
Didn't seem to do anything ... I checked to see what code
is equal to upon entry into that function and the value is 13. It looks like key
is set to a newline character in either version of the code. Not sure if that helps.
Could you try to replace '\n' in core/buffer.lua (https://github.com/rgieseke/textredux/blob/master/core/buffer.lua#L536) with something else, eg '!' or 'co' (for Ctrl-O) to trigger the selection? Also, what platform are you on?
In any case, I'm quite certain that I'll be able to move to the key modes after I looked at them a bit yesterday...
That worked! I changed it to a '!'. I'm on a Debian box:
kaz@monad:~/.textadept/modules/textredux$ uname -a
Linux monad 3.2.0-4-amd64 #1 SMP Debian 3.2.39-2 x86_64 GNU/Linux
If it will help, I can give you access to the box.
Odd that it's not working -- I just tested on a Ubuntu 12.04 virtual machine and it worked fine (I mainly develop on OS X). I'm working on getting a current version to compile and look into key modes. Hopefully this will get it to work for you as well.
Could you try the latest Textredux master with Textadept 6.6 beta? I had the problem again and now I've hardcoded handling code '13' as '\n'.
Works for me now! Thank you!
On May 2, 2013, at 11:26 AM, Robert Gieseke notifications@github.com wrote:
Could you try the latest Textredux master with Textadept 6.6 beta? I had the problem again and now I've hardcoded handling code '13' as '\n'.
— Reply to this email directly or view it on GitHub.
I just tried textredux today, and hit this issue. It looks like the workaround was removed a couple of days ago; was there a reason for that?
What Textadept version/OS are you on? I should have worded the changelog better as it meant to only be compatible with 6.6 and 7.0 alpha. With 6.6 Textadept changed to
Use '\n' keycode in curses instead of '\r'; src/textadept.c Win32-curses still uses '\r' since pdcurses reports it.
(http://foicica.com/hg/textadept/rev/984c47939bc3)
I didn't notice the Win32 remark so your pull request is hopefully a great solution for older Textadept versions (and Windows), thanks!
(See also this later commit in Textadept: http://foicica.com/hg/textadept/rev/e892961d46e8)
I'm using Textadept built from recent Hg (plus the 7.0 source for parts not in Hg), including the commit you mention, on Debian 6.0.
I've just tried it on my Ubuntu 13.04 laptop, and there it doesn't seem to be necessary. There's a possibility of me being confused about what version I'm running when, so let me know if you'd like to be more certain about these facts and I'll check again.
Thanks for the merge!
How does one actually choose a file or buffer? Is it supposed to be enter/return? For some reason, I can't choose anything from the lists (filtering works great). I'm using the curses version of textadept. I've tried a couple versions of textadept (hg version, 6.5, 6.2). Thanks!