search

rgieseke / textredux

Text-based interfaces for Textadept
http://rgieseke.github.io/textredux/
Other
59 stars 11 forks source link

Fix buffer line number background color #45

Closed ghost closed 5 years ago

ghost commented 5 years ago

The buffer line number margin background color is different from the buffer background color. This "fixes" itself after e.g. deleting an item from the buffer list. IMO it's better to always have the same style and not just after arbitrary changes to the list.

rgieseke commented 5 years ago

Thanks! I use some code to highlight the active view by coloring the margin in the color of the current line:

https://github.com/rgieseke/ta-common/blob/master/highlight.lua

That's probably why i never noticed this. One way would be to fix the restyling in Textredux, the other to never change the margin style in Textredux. Did you mind the margin styling?

ghost commented 5 years ago

Considering that it switches to the default background color after interaction, I think it's not working as intended and should be fixed. It's unlikely to break anything. Especially if people use the highlighter script you linked.

rgieseke commented 5 years ago

I need to check this more careful because i think as it stands now it breaks the code border highlighting. Fully agreed on not working as expected ...

ghost commented 5 years ago

Have you looked into this? Curious as well if this has any side-effects.

rgieseke commented 5 years ago

Not really looked into a fix for my other highlighting, but let's merge it!

rgieseke commented 5 years ago

Thanks for the reminder!