search

rgieseke / textredux

Text-based interfaces for Textadept
http://rgieseke.github.io/textredux/
Other
59 stars 11 forks source link

Fix select_directory #46

Closed ghost closed 5 years ago

ghost commented 5 years ago

Slight changes

rgieseke commented 5 years ago

The key seems a simpler way to do it, a Windows fix always be welcome, but the elseifblock seems to be empty?

ghost commented 5 years ago

but the elseifblock seems to be empty?

Indeed. It gets rid of the trailing '.' I updated the code, maybe you enjoy this version more.

triplejam commented 5 years ago

@loomer The windows and key changes are fine as far as I know. But I think fixing the directory name should be done in the normalize_dir_path function. Also I think you might be changing the file permissions by accident.

rgieseke commented 5 years ago

@triplejam thanks for chiming in, could you give this another look and then i'm happy to merge this!

Thanks @loomer !

triplejam commented 5 years ago

@loomer I just tested it and it works fine.

rgieseke commented 5 years ago

Awesome! Thanks @triplejam and @loomer