Snapopen broken with TA 10.5

rgieseke / textredux

Text-based interfaces for Textadept

http://rgieseke.github.io/textredux/

Other

59 stars 11 forks source link

Snapopen broken with TA 10.5 #50

Closed ghost closed 5 years ago

ghost commented 5 years ago

It seems the recent TA update to 10.5 broke the snapopen functionality in TR.
Looking at the code it's easy to see that the filters no longer match between the two. However that should have broken much earlier than it did.

I don't know if you're already working on a fix so I came up with https://github.com/loomer/textredux/commit/3e626d6556a6ba7bac5e4382b84e2fc4b5009387 which maps the filters to the old ones that TR is using.

What is your take on this?

rgieseke commented 5 years ago

It's probably worth updating to be in line with Textadept, but for me it still works with TA 10.5. Do you use any special filters?

rgieseke commented 5 years ago

Ah, sorry, now i get the error... !

rgieseke commented 5 years ago

Care to submit a PR?