search

rgieseke / textredux

Text-based interfaces for Textadept
http://rgieseke.github.io/textredux/
Other
58 stars 11 forks source link

Filters when using quick_open via toggle #60

Closed ghost closed 3 years ago

ghost commented 4 years ago

It seems lfs.default_filter does not apply when using quick_open via the toggle (default: ctrl+s in the open dialog).
I tried to fix this here: https://github.com/loomer/textredux/commit/b200c1e880a6a1a344ea243a97d0331c2b832f3f
The code is rather brittle though as it was originally just designed to make quick_open work again after it was broken by some TA updates. It makes some assumptions about the structure of filter entries but does work. The existing filter system in TR seems quite messy and overhauling all of it would probably be a fairly big task.

What is your take on this?

rgieseke commented 4 years ago

Agreed, it's a big task and hasn't caught up with TA's API changes over time ... don't know how to best tackle it ...

snoopy commented 3 years ago

Should be fixed with https://github.com/rgieseke/textredux/commit/2b12ad657a22f4ca9859d3ab747c92b75a1bf3a2
At least I can't reproduce the issue described in the OP so this can probably be closed?

rgieseke commented 3 years ago

Agreed!