search

rgieseke / textredux

Text-based interfaces for Textadept
http://rgieseke.github.io/textredux/
Other
59 stars 11 forks source link

Update ui.dialogs.* to match API changes #82

Closed snoopy closed 1 year ago

snoopy commented 1 year ago

See https://orbitalquark.github.io/textadept/api.html#ui.dialogs.

This updates the names of ui.dialogs according to the new API. Wrapped lists now show up properly again but do NOT work yet. I haven't had much time to look into it but I suspect list API changes prevent them from fully working.

Maybe something to do with these lines:

https://github.com/rgieseke/textredux/blob/5abf1ac4e69119ab74247186d7ed4bbfbc6bf50b/core/filteredlist.lua#L52

https://github.com/rgieseke/textredux/blob/5abf1ac4e69119ab74247186d7ed4bbfbc6bf50b/core/filteredlist.lua#L54

rgieseke commented 1 year ago

This updates the names of ui.dialogs according to the new API. Wrapped lists now show up properly again but do NOT work yet.

Still good to merge as it fixes the other dialogs, right?

snoopy commented 1 year ago

[...] Still good to merge as it fixes the other dialogs, right?

Yeah, just letting you know there is more work to be done.

rgieseke commented 1 year ago

Great, thank you!

rgieseke commented 1 year ago

I think i fixed (some of?) the list wrapping https://github.com/rgieseke/textredux/commit/646a9fa46fa363e1cf231ac11c315275199b55ef