search

rgiordan / zaminfluence

Tools in R for computing and using Z-estimator approximate influence functions.
Apache License 2.0
94 stars 10 forks source link

Wrong signal used for changes to both sign and significance for significant, positive estimates #24

Closed rgiordan closed 2 years ago

rgiordan commented 2 years ago

There is a typo in .GetInferenceSignalsForParameter that picks up the wrong end of the confidence interval in this case.

rgiordan commented 2 years ago

Fixed in master, but leaving this issue open until I make a unit test to catch this kind of thing in the future.

rgiordan commented 2 years ago

I think this may be overtesting, and I'm going to close the issue.