search

rgl / MailBounceDetector

Detects whether a MailKit email Message is a bounce message
MIT License
28 stars 13 forks source link

.net core build #3

Open SharpeRAD opened 8 years ago

SharpeRAD commented 8 years ago

Firstly I should apologize for replacing "make" with "cake"!

Changing another dev's preferred toolset isn't cool but I :heart: :cake: and I'm hoping that after you look at their excellent documentation and run my example build script you'll see the future :wink:

SharpeRAD commented 8 years ago

All you need to do is add an environment variable to AppVeyor named "NUGET_API_KEY" and run the build again to publish the package, then you too will :heart: :cake:

SharpeRAD commented 8 years ago

Hey any chance you can look over my PR :smile:

rgl commented 8 years ago

I mostly use Makefiles for simpler projects like this one. It makes things easier to understand. I'm not sure about committing to cake just yet. Mainly because I'm not familiar with it. I'll eventually look at it when I have the time, but, I'm busy with other things and allocating quality time for this is going to be hard for me, so I can't promise when I'm going to look at it.

But one thing is for sure, .NET Core support is welcome :-)

I have some observations about your pull request.

You should make sure you don't change the existing line endings. When you do that, the diffs are unnecessary noisy and skew the history.

Also be vigilant about the contents of the .gitignore file because the one you've committed is too verbose and has unnecessary entries. Also drop the .gitattributes file, it has no useful information for this project.

Now that you've seem to have stabilized the changes you should squash them together into a single patch; this will make the history simpler and the maintainer life easier.

rklec commented 6 days ago

This is quite old, so what is the status here now?