rgl / packer-plugin-windows-update

Packer plugin for installing Windows updates
Mozilla Public License 2.0
302 stars 71 forks source link

Feature/retry on install failure #77

Closed pvandervelde closed 4 years ago

pvandervelde commented 4 years ago

In some cases the installation of Windows Updates fails for obscure reasons. Forcing the machine to restart and retry the updates seems to allow the updates to be applied without issues.

Code changes have been tested in production and do fix the issue. Note that one worry about this code change is that of an infinite loop of restarts if the update keeps failing. Not entirely sure if that is a real issue (i.e. could that occur) and how to determine that is the case and break the loop.

relates to #76

rgl commented 4 years ago

Seems like a reasonable change. Thank You for looking into this!