search

rgl / windows-domain-controller-vagrant

Example Windows Domain Controller
140 stars 35 forks source link

Use rsync to sync folder with libvirt provider #7

Closed roblabla closed 3 years ago

roblabla commented 3 years ago

smb sync folder method only works on windows and MacOS host machines, according to this, causing the build to fail. Using rsync works without issues.

rgl commented 3 years ago

I'm using it in linux too, but I have to manually apply https://github.com/hashicorp/vagrant/pull/9948 (using the https://patch-diff.githubusercontent.com/raw/hashicorp/vagrant/pull/9948.patch file) to my local vagrant installation.

I still haven't gotten around for fleshing out the unit tests needed for that PR to be merged in vagrant.

The environment in this repo copies a file to the host vagrant share:

https://github.com/rgl/windows-domain-controller-vagrant/blob/29c54af3736a229f4215cb52abd0336cf66c2bae/provision/ca.ps1#L32-L36

That file is used by other environments (e.g. https://github.com/rgl/gitlab-vagrant), so I have to keep using SMB.

~Though, I can merge the PR when you change it to be something alike:~ Actually this will not work... the ubuntu test node also needs to access tmp/ExampleEnterpriseRootCA.der, so this is a no go for me.


if ENV['VAGRANT_SMB_PASSWORD']
  ... smb line
else
  ... rsync line
end
roblabla commented 3 years ago

Ah, awesome. I don't personally use the ubuntu test node, so I guess I'll keep doing this locally.

Having a bit in the README to let people know they need a custom vagrant build with https://github.com/hashicorp/vagrant/pull/9948 on linux would probably be helpful ^^.