search

rgl / windows-vagrant

Windows 11/2022/2025 Base Vagrant Box (https://app.vagrantup.com/rgl)
MIT License
362 stars 95 forks source link

Add clean target to Makefile #19

Open oxr463 opened 2 years ago

oxr463 commented 2 years ago

These invocations of rm -rf $@ for each target in the Makefile should be put in a separate clean target. That way it doesn't remove everything each time the user re-runs make.

This would be especially helpful for all of the large files that are downloaded during the build process.

oxr463 commented 2 years ago

A good example would be this: https://github.com/rgl/windows-vagrant/issues/20

rgl commented 2 years ago

Not sure what you mean. What do you think it's being deleted, why and when?

oxr463 commented 2 years ago

One example is this line: https://github.com/rgl/windows-vagrant/blob/master/Makefile#L205

Deleting that directory also deletes the ISO that gets downloaded, which is over 1GB.