search

rgladwell / imap-upload

Python script for uploading a local mbox file to IMAP4 server.
Other
130 stars 30 forks source link

Feature/google takeout label priority #45

Closed poldy79 closed 2 years ago

poldy79 commented 2 years ago

Set of two commits to add a feature to upload a google takeout mbox to non gmail imap acounts in a way that makes more sense.

poldy79 commented 2 years ago

Please do not merge this pullrequest yet, i found some logic in function begin which does not work properly with other languages than "en" as the translated Strings are beeing used for comparison while all occurences of the label names are already renamed to english values.

E.g. "Ungelesen" is converted to "Unread", but the label is not beeing detected with languages other than "en" as "Ungelesen" is searched in the label list. I will try to understand this issue before this pull request is merged...

poldy79 commented 2 years ago

For tests I have switched to a different account - and it seems that this is not "de" but "en". Using "de" on an "en" leads to wrong filtering of labels.

rgladwell commented 2 years ago

Sorry for the delay in responding to this. I'm on holiday this week, will try and get back to this next week.

rgladwell commented 2 years ago

Is there any update on this, or shall I leave it for a bit?

adriangibanelbtactic commented 2 years ago

Furtermore "Archived" is only selected, if no other label matches - so it is a hardcoded low-priority-label.

This being hardcoded is ok with me.

poldy79 commented 2 years ago

I think it does no harm and perhaps it is handy to have it, altough my need has decerased as I have fixed some tranlations of the Predefined labels (I have to create some more pull requests).

rgladwell commented 2 years ago

Thank you for this, if you could resolve the merge conflicts, I'll merge ASAP.

rgladwell commented 2 years ago

Thanks!