rgleason / watchdog_pi

watchdog plugin for opencpn
GNU General Public License v3.0
1 stars 9 forks source link

Bug: Wind T-A and Wind T-R don't seem to work anymore. #107

Open rgleason opened 6 months ago

rgleason commented 6 months ago

WIND.txt Using this file Wind.txt

with these MWD - Wind Direction & Speed Line 16: $IIMWD,,,197,M,12.7,N,6.5,M18 Line 44: $IIMWD,,,185,M,12.0,N,6.2,M1B Line 81: $IIMWD,,,182,M,11.1,N,5.7,M18 Line 114: $IIMWD,,,187,M,11.0,N,5.7,M1

Also has these MWV - Wind Speed and Angle
R=Relative T=True Looks like file only has Relative Line 12: $IIMWV,208,R,7.2,N,A2C Line 40: $IIMWV,170,R,5.8,N,A28 Line 73: $IIMWV,181,R,5.0,N,A2E Line 112: $IIMWV,192,R,5.4,N,A28

VWR - Relative Wind Speed and Angle Apparent wind, Left or Right of Bow. Line 15: $IIVWR,152,L,7.2,N,3.7,M,13.3,K7F Line 43: $IIVWR,170,R,5.8,N,3.0,M,10.7,K69 Line 78: $IIVWR,179,L,5.0,N,2.6,M,9.3,K4D Line 113: $IIVWR,168,L,5.4,N,2.8,M,10.0,K7C

I don't seem to get anything showing in Watchdog Wind Alerts. I thought these were working before here..

Perhaps Werner will test this and advise.

rgleason commented 6 months ago

I am finding that

  1. Wind T-A (True Absolute) Direction MWD - Wind Direction & Speed
  2. Wind T-A (True Absolute) Overspeed
  3. Wind T-A (True Absolute) Underspeed
  4. Wind T-R (True Relative) Direction MWV - Wind Speed and Angle
  5. Wind T-R (True Relative) Overspeed
  6. Wind T-R (True Relative) Underspeed Don't really work that well.

Overspeed and Underspeed

Overspeed-underspeed Display should show Wind T-A [Dashboard Overspeed or Underspeed ] </> [Entered Value] and change sign and color. Wind T-R [Dashboard Overspeed or Underspeed ] </> [Entered Value] and change sign and color.

Similar to the Wind-App lower two lines in the screenshot above.

This applies to

  1. Wind T-A (True Absolute) Overspeed
  2. Wind T-A (True Absolute) Underspeed
  3. Wind T-R (True Relative) Overspeed
  4. Wind T-R (True Relative) Underspeed

Direction/Angle

Direction-Angle

Display should show just like the Wind-App (Apparent Wind) in the screenshot

Wind T-A Lower number set by direction & range </> Dashboard Wind Direction </> Upper Value set by direction and range

This applies to

  1. Wind T-A (True Absolute) Direction
  2. Wind T-R (True Relative) Dirction
rgleason commented 5 months ago

Received an email from Werner re Watchdog.

Rudder Alarm seems to work fine. Also tested various wind alarms. Works pretty well, as far as I can see, where I did some random tests, not a systematical test.

2 remarks:

  1. There is a difference in the how the range is treated. For TWD one can specify lower and upper limit. For TWA one cannot, and range is a 15 degree interval. That is inconsistent, and raises questions. Why not the same implementation? Would make it easier to use, to understand, and to maintain and test the code base. So For the True Wind - Absolute I can say: 43 +/- 10, so the alarms goes outside 33 and 53. I would expect that for the other wind angles as well.

  2. I am still confused by the terminology: True Wind relative and True Wind absolute. Wouldn't it make more sense to use the same terminology as the Dashboard? Apparent Wind: Angle and Speed True Wind: Angle and Speed True Wnd: Direction With that terminology it is consistent with Dashboard.

For True Wind: Direction there seems no need for 'Speed' since that is the same is True Wind: Angle and Speed (though it won't harm either if it would be there).

Those remarks could be considered improvements, for the Ux, and have nothing to do with the bug.

I will try testing this again and try to clarify and clean up this Issue. Wind was not working well for me.