search

rgleason / watchdog_pi

watchdog plugin for opencpn
GNU General Public License v3.0
1 stars 10 forks source link

Watchdog still probes old version of pypilot #33

Closed marcobergman closed 1 year ago

marcobergman commented 2 years ago

Please merge the august 26th commit 7f7c655 from seandepagnier; this commit upgrades the watchdog for modern versions of pypilot. Without this, it cannot connect to pypilot: image

rgleason commented 2 years ago

Thanks, was not aware of this. Will do, but remind me if I forget....please.

rgleason commented 1 year ago

Pypilot Alarm has been removed from Watchdog now

marcobergman commented 1 year ago

Must say, that was not my intention.

rgleason commented 1 year ago

Yes, but it is my intention, and not your fault at all. Please see https://github.com/rgleason/watchdog_pi/issues/40

Very Sorry about this. If you want it, you could fork my version and make a PR that actually works for Pypilot Alarm and I will very gladly accept it.

I don't have the skill or the time to fix this and have tried many x's to get my repos aligned with Sean's,,, (not too much interest there) and I am finished with trying that.

rgleason commented 1 year ago

PS: I left the remnants of the Pypilot Alarm in the code, just commented out. However Sean's version does some disastrous things like deleting files that are needed, then adding new files with a different name, etc. which then merge with all kinds of conflicts no matter what I try to do. It is a mess I don't want to get into.

marcobergman commented 1 year ago

Thx for your response, I understand now. I don't qualify to attempt such a modification so I will leave it at this.