search

rgleason / weather_routing_pi

Weather Routing plugin for OpenCPN
GNU General Public License v3.0
12 stars 14 forks source link

Broken URLs in current catalog #76

Closed leamas closed 3 years ago

leamas commented 3 years ago

As heading says: One broken weatherrouting url in current catalog.

check logfile: urlcheck.log

rgleason commented 3 years ago

That is a pretty amazing checker. We have moved on to v1.13.30.2 now (not accepted by bdb yet) so what is needed here? I thought this was being checked by the scripts in OpenCPN/plugiins?

2 urls checked, 0 errors
======> Checking metadata/weather_routing_pi-1.13.30.0-darwin-x86_64-11.4-macos.xml
.Ehttps://dl.cloudsmith.io/public/opencpn/weather-routing-prod/raw/names/weather_routing_pi-1.13.30.0-darwin-x86_64-11.4-macos-tarball/versions/v1.13.30.0/weather_routing_pi-1.13.30.0-darwin-x86_64-11.4-macos.tar.gz: 404

2 urls checked, 1 errors
======> Checking metadata/weather_routing_pi-1.13.30.0-debian-x86_64-10-buster.xml
leamas commented 3 years ago

As Jon have explained, urls are not checked by the script at OpenCPN/plugiins. He also claims (and I agree) that it isn't possible for performance reasons.

Which leaves us with the pre-commit hook -- it should check each and every url before it's committed. If you used that hook, the explanation is that the tarball at cloudsmith no longer is available for some reason.

leamas commented 3 years ago

We have moved on to v1.13.30.2

The check is run on current catalog which obviously is 1.13.30.0.

The important thing here is not the broken url, it the fact that we have (had?) a process which commits broken urls into the catalog. We really need to come to a point where this just don't happens.

rgleason commented 3 years ago

I am sorry I was not paying attention to that discussion. How can I use the hook?

If you used that hook, the explanation is that the tarball at cloudsmith no longer is available for some reason.

We need this in the dev-manual too. I used to run a checker that checked all urls.

leamas commented 3 years ago

Work in the plugins project, easiest in git-bash.

  1. Checkout master branch
  2. Update to latest version using git pull or (better) git rebase.
  3. Copy the pre-commit hook to location where it's used: $ cp pre-commit .git/hooks
leamas commented 3 years ago

I used to run a checker that checked all urls.

The hook is so much better. It only checks the updated urls, so it's reasonably fast. And it's run automatically when doing git commit.

rgleason commented 3 years ago

Yes, now I remember this technique. You had me do it for ocpn-manuals to check for line endings. It was a pain at first.

rgleason commented 3 years ago

WR has been removed and a new version added later.