rgocal / dex2jar

Automatically exported from code.google.com/p/dex2jar
1 stars 0 forks source link

ASM4 #77

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
ASM4 uses abstract classes instead of interfaces for visitors, e.g.

http://websvn.ow2.org/filedetails.php?repname=asm&path=%2Ftrunk%2Fasm%2Fsrc%2For
g%2Fobjectweb%2Fasm%2FMethodVisitor.java

May be it's to early but plz think about converting to ASM4...only a reminder 
yet.

Or don't use ASM base visitor classes? Doesn't look this important to use them 
- the ASM/SAX-style concept can also be established without the ASM dependency.

Why is this important? Because I would like to use ASM4 because of new JDK7 
features and cannot mix with dex2jar libs ;)

Original issue reported on code.google.com by andrePan...@gmail.com on 24 Sep 2011 at 11:53

GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
hi thx for comment and acceptance.

for me it would be enough to make dex-reader independant from ASM3.
I think you only use Label, Type, Opcode, AnnotationVisitor from ASM there and 
that wouldn't be necessary and adds a rather complex dependency.

These 4 classes (and often you only use minor parts for DEX) could be in the 
reader-package and be dex-specific.

i absolutely understand that ASM is needed for the java bytecode generation, 
but dex-reader in itself is a valueable component and you could improve 
reusability through removing the (minor) ASM dependency there - especially 
where the ASM guys continue to severe change the interfaces in each version ;)

thx for the great work!

Original comment by andrePan...@gmail.com on 25 Sep 2011 at 11:07

GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
big thx! can now use ASM4 and dex-reader-1.2 libs together

Original comment by andrePan...@gmail.com on 25 Sep 2011 at 7:55