LED pin is set as output even if it is not needed

[GoogleCodeExporter]

What steps will reproduce the problem?
Compile optiboot without LED_START_FLASHES and LED_DATA_FLASH defined.

What is the expected output? What do you see instead?
In the presented conditions, no operations should be performed on the LED pin 
but is set as output.

What version of the product are you using? On what operating system?
optiboot 4.5

Please provide any additional information below.

In optiboot.c this:
  /* Set LED pin as output */
  LED_DDR |= _BV(LED);
should be changed like this:
#if LED_START_FLASHES > 0 || defined(LED_DATA_FLASH)
  /* Set LED pin as output */
  LED_DDR |= _BV(LED);
#endif

Original issue reported on code.google.com by calin.ra...@gmail.com on 8 May 2012 at 6:30

[GoogleCodeExporter]

Original comment by wes...@gmail.com on 17 May 2012 at 5:39

• Changed state: Accepted
• Added labels: Priority-Low
• Removed labels: Priority-Medium

[GoogleCodeExporter]

http://code.google.com/p/optiboot/source/detail?r=1d5f7c960b2224fc3dde92f4c1d667
b27cbf5a01

Original comment by wes...@gmail.com on 9 Mar 2013 at 6:10

• Changed state: Fixed